[webkit-reviews] review denied: [Bug 112689] Web Inspector: factor out node search controller from inspector.js : [Attachment 193810] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 112689: Web Inspector: factor out node search controller from inspector.js
https://bugs.webkit.org/show_bug.cgi?id=112689

Attachment 193810: Patch
https://bugs.webkit.org/attachment.cgi?id=193810&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193810&action=review


> Source/WebCore/inspector/front-end/AdvancedSearchController.js:47
> +    return WebInspector.KeyboardShortcut.makeDescriptor("f",
WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta |
WebInspector.KeyboardShortcut.Modifiers.Shift);

It was Alt

> Source/WebCore/inspector/front-end/InspectorFrontendAPI.js:110
> +	   if (WebInspector.nodeSearchController)

This is now called inspectElementMode