[webkit-reviews] review denied: [Bug 111334] Web Inspector: Plumbing CSS warnings : [Attachment 193544] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 19 09:27:59 PDT 2013
Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 111334: Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334
Attachment 193544: Patch
https://bugs.webkit.org/attachment.cgi?id=193544&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193544&action=review
> Source/WebCore/css/CSSParser.cpp:10553
> + m_tokenStartLineNumber = m_lineNumber;
This field seems to be unused.
> Source/WebCore/css/CSSParser.cpp:11239
> +
m_styleSheet->singleOwnerDocument()->page()->console()->addMessage(CSSMessageSo
urce, WarningMessageLevel, message, m_styleSheet->baseURL().string(),
lineNumber + 1);
Intermediate variable would not hurt.
More information about the webkit-reviews
mailing list