[webkit-reviews] review granted: [Bug 106013] [Qt] Support kerning in fast path font rendering : [Attachment 193818] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 08:56:38 PDT 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 106013: [Qt] Support kerning in fast path font rendering
https://bugs.webkit.org/show_bug.cgi?id=106013

Attachment 193818: Patch
https://bugs.webkit.org/attachment.cgi?id=193818&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193818&action=review


> Source/WebCore/platform/graphics/SimpleFontData.h:209
> +#elif PLATFORM(QT) && QT_VERSION >= 0x050100

QT_VERSION_CHECK?

> Source/WebCore/platform/graphics/WidthIterator.h:69
> +#elif PLATFORM(QT) && QT_VERSION >= 0x050100

ditto

LGTM too for the rest, r=me.


More information about the webkit-reviews mailing list