[webkit-reviews] review granted: [Bug 94782] [Qt] Make ImageDiff similar to Chromium's ImageDiff : [Attachment 193831] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 08:29:55 PDT 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 94782: [Qt] Make ImageDiff similar to Chromium's ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=94782

Attachment 193831: Patch
https://bugs.webkit.org/attachment.cgi?id=193831&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193831&action=review


>> Tools/ImageDiff/qt/ImageDiff.cpp:109
>> +			    if (distance > fuzz) {
> 
> ditto

r=me if you replace this with distance > 0 and remove the fuzz variable.


More information about the webkit-reviews mailing list