[webkit-reviews] review requested: [Bug 112688] [Qt] QStyle: Invalid rendering of button elements (missing enabled state) : [Attachment 193828] Patch with changelog 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 07:44:42 PDT 2013


Pierre Rossi <pierre.rossi at gmail.com> has asked  for review:
Bug 112688: [Qt] QStyle: Invalid rendering of button elements (missing enabled
state)
https://bugs.webkit.org/show_bug.cgi?id=112688

Attachment 193828: Patch with changelog 2
https://bugs.webkit.org/attachment.cgi?id=193828&action=review

------- Additional Comments from Pierre Rossi <pierre.rossi at gmail.com>
Looks reasonable to me. The other option was to add an else statement to the if
(!isEnabled(o)) a bit below... I guess it's a matter of taste.


More information about the webkit-reviews mailing list