[webkit-reviews] review denied: [Bug 112651] SVG image container size can survive cached reloads : [Attachment 193736] Separate SVG image size and container size

Tue Mar 19 06:43:46 PDT 2013

Stephen Chenney <schenney at chromium.org> has denied Philip Rogers
<pdr at google.com>'s request for review:
Bug 112651: SVG image container size can survive cached reloads
https://bugs.webkit.org/show_bug.cgi?id=112651

Attachment 193736: Separate SVG image size and container size
https://bugs.webkit.org/attachment.cgi?id=193736&action=review

------- Additional Comments from Stephen Chenney <schenney at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193736&action=review

The wk2 test is a flake, so don't worry about that. Otherwise I'm basically
happy, but it could do with a little polish.

> Source/WebCore/svg/graphics/SVGImage.h:54
> +    virtual IntSize size() const OVERRIDE { return m_intrinsicSize; }

Can this now be renamed "instrinsicSize" to make it clear what this size means?

> LayoutTests/svg/as-image/svg-container-size-after-reload.html:2
> +<html>

This kind of testing looks to be in the same format as the svg dynamic-tests
or, more simply, the js pre/post test harness. Your loading some content and
running some script and checking the values. Please try to convert to that
format.