[webkit-reviews] review denied: [Bug 112586] Web Inspector: Switch Drawer animation from JavaScript to CSS transitions. : [Attachment 193794] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 112586: Web Inspector: Switch Drawer animation from JavaScript to CSS
transitions.
https://bugs.webkit.org/show_bug.cgi?id=112586

Attachment 193794: Patch
https://bugs.webkit.org/attachment.cgi?id=193794&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193794&action=review


> Source/WebCore/inspector/front-end/Drawer.js:114
> +	   if (this._viewStatusBar.style.opacity == 1 || animationType ==
WebInspector.Drawer.AnimationType.Immediately )

We use === everywhere.

Also, an extraneous whitespace before ')'

> Source/WebCore/inspector/front-end/Drawer.js:156
> +	   if (this._viewStatusBar.style.opacity == 0 || animationType ==
WebInspector.Drawer.AnimationType.Immediately )

I seem to have seen this somewhere? :) Is the diff/patch correct?