[webkit-reviews] review denied: [Bug 112669] Web Inspector: Add Inspector.targetCrashed event to Inspector protocol : [Attachment 193776] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 112669: Web Inspector: Add Inspector.targetCrashed event to Inspector
protocol
https://bugs.webkit.org/show_bug.cgi?id=112669

Attachment 193776: Patch
https://bugs.webkit.org/attachment.cgi?id=193776&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193776&action=review


> Source/WebCore/inspector/Inspector.json:42
> +		   "parameters": []

This is optional.

> Source/WebCore/inspector/front-end/HelpScreen.js:147
> +	  
WebInspector.debuggerModel.removeEventListener(WebInspector.DebuggerModel.Event
s.GlobalObjectCleared, this.hide, this);

I would not override this. Just call the bound function that closes and removes
the listener.

> Source/WebCore/inspector/front-end/inspector.js:985
> +WebInspector.targetCrashed = function() {

{ on the next line.

> Source/WebCore/inspector/front-end/inspector.js:987
> +	   WebInspector.UIString("Target has crashed"),

Please add these strings into localizedStrings.