[webkit-reviews] review granted: [Bug 112669] Web Inspector: Add Inspector.targetCrashed event to Inspector protocol : [Attachment 193752] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 112669: Web Inspector: Add Inspector.targetCrashed event to Inspector
protocol
https://bugs.webkit.org/show_bug.cgi?id=112669

Attachment 193752: Patch
https://bugs.webkit.org/attachment.cgi?id=193752&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193752&action=review


> Source/WebCore/ChangeLog:7
> +

Please provide a description.

> Source/WebCore/inspector/front-end/HelpScreen.js:134
> +    WebInspector.HelpScreen.call(this, title);

I think it's time to rename HelpScreen into OverlayScreen or something as it is
not actually a help screen anymore.