[webkit-reviews] review denied: [Bug 112586] Web Inspector: Switch Drawer animation from JavaScript to CSS transitions. : [Attachment 193598] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 112586: Web Inspector: Switch Drawer animation from JavaScript to CSS
transitions.
https://bugs.webkit.org/show_bug.cgi?id=112586

Attachment 193598: Patch
https://bugs.webkit.org/attachment.cgi?id=193598&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193598&action=review


> Source/WebCore/inspector/front-end/Drawer.js:-104
> -	   function animationFinished()

Why was this function removed?

> Source/WebCore/inspector/front-end/Drawer.js:130
> +	   this.animationFinished = function()

Please make it a named function
function animationFinshed()
{
 ...
}
this._animationFinished = animationFinished;

> Source/WebCore/inspector/front-end/Drawer.js:141
> +	   if (this._viewStatusBar.style.opacity == 0 || animationType ==
WebInspector.Drawer.AnimationType.Immediately )

What does this condition check: this._viewStatusBar.style.opacity == 0 ?