[webkit-reviews] review granted: [Bug 112464] Copy-paste should not spellcheck when continuous spellcheck is turned off : [Attachment 193711] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 112464: Copy-paste should not spellcheck when continuous spellcheck is
turned off
https://bugs.webkit.org/show_bug.cgi?id=112464

Attachment 193711: Patch
https://bugs.webkit.org/attachment.cgi?id=193711&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193711&action=review


Please fix the Windows build before you land.

> Source/WebCore/testing/Internals.cpp:1513
> +    if (!contextDocument() || !contextDocument()->frame() ||
!contextDocument()->frame()->editor())
> +	   return;
> +
> +    if (enabled !=
contextDocument()->frame()->editor()->isContinuousSpellCheckingEnabled())
> +	  
contextDocument()->frame()->editor()->toggleContinuousSpellChecking();

It's somewhat strange that this isn't a setting but I guess that's outside of
the scope of this bug.