[webkit-reviews] review granted: [Bug 112475] Add IDL 'enum' support to CodeGeneratorJS.pm : [Attachment 193621] patch modification: use a reference to String to avoid a copy

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted arno. <arno at renevier.net>'s
request for review:
Bug 112475: Add IDL 'enum' support to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112475

Attachment 193621: patch modification: use a reference to String to avoid a
copy
https://bugs.webkit.org/attachment.cgi?id=193621&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193621&action=review


LGTM, thanks!

> Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:1892
> +    if (args.Length() < 1)
> +	   return throwNotEnoughArgumentsError(args.GetIsolate());
> +    TestObj* imp = V8TestObj::toNative(args.Holder());
> +    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, enumArg, args[0]);
> +    imp->methodWithEnumArg(enumArg);
> +    return v8Undefined();

If you have time, I'd be happy if you could support 'enum' in DOM methods in V8
as well.