[webkit-reviews] review granted: [Bug 110034] Need a bundle SPI to generate a snapshot of a specific DOM node : [Attachment 193693] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 110034: Need a bundle SPI to generate a snapshot of a specific DOM node
https://bugs.webkit.org/show_bug.cgi?id=110034

Attachment 193693: Patch
https://bugs.webkit.org/attachment.cgi?id=193693&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193693&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:32
> -- (WKBundleNodeHandleRef)_copyWKBundleNodeHandleRef;
> +- (WKBundleNodeHandleRef)_copyBundleNodeHandleRef;

Is nobody going to mind this?

> Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:132

> +    OwnPtr<WebCore::GraphicsContext> graphicsContext =
snapshot->bitmap()->createGraphicsContext();

Drop the WebCore::, I think.