[webkit-reviews] review granted: [Bug 112525] AXObjectCache gets recreated during document tear-down : [Attachment 193672] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 112525: AXObjectCache gets recreated during document tear-down
https://bugs.webkit.org/show_bug.cgi?id=112525

Attachment 193672: patch
https://bugs.webkit.org/attachment.cgi?id=193672&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193672&action=review


> Source/WebCore/dom/ContainerNode.cpp:144
> +    if (documentInternal()) {
> +	   if (AXObjectCache* cache =
documentInternal()->existingAXObjectCache())
> +	       cache->remove(this);
> +    }

The destructor seems very late to do this. Why not ContainerNode::detach()?

I assume that AXObjectCache doesn't hold refs to Node, otherwise there would be
a ref cycle.

> Source/WebCore/dom/Document.cpp:3488
>  #if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(CHROMIUM)

Why just these?