[webkit-reviews] review granted: [Bug 112599] DFG should inline binary string concatenations (i.e. ValueAdd with string children) : [Attachment 193612] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 112599: DFG should inline binary string concatenations (i.e. ValueAdd with
string children)
https://bugs.webkit.org/show_bug.cgi?id=112599

Attachment 193612: the patch
https://bugs.webkit.org/attachment.cgi?id=193612&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me.

I've found myself pondering making us plant calls to the valueOf functions in
the DFG, that way the function calls are cacheable and we could add intrinsics
for the more common implementations, and custom calls would "just work"

That said i'm not sure how much of a win that would be for concat, etc now that
the common case of String objects is handled.  But I do recall toString being
sufficiently common on generic objects to be something we might consider
investigating in future.

Other than that, make the qt bots non-red (!PLATFORM(QT) ?) and r=me