[webkit-reviews] review granted: [Bug 112571] [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring : [Attachment 193603] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 112571: [Chromium] Create WebFileSystemType enum to allow easier filesystem
refactoring
https://bugs.webkit.org/show_bug.cgi?id=112571

Attachment 193603: Patch
https://bugs.webkit.org/attachment.cgi?id=193603&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193603&action=review


> Source/Platform/chromium/public/WebFileSystemType.h:35
> +// #define USE_NEW_WEBFILESYSTEMTYPE

USE_NEW_WEBFILESYSTEMTYPE -> WEBKIT_USE_NEW_WEBFILESYSTEMTYPE

> Source/WebKit/chromium/public/WebCommonWorkerClient.h:67
> +#ifdef USE_NEW_WEBFILESYSTEMTYPE
> +    virtual void openFileSystem(WebFileSystemType, long long size, bool
create, WebFileSystemCallbacks*)
> +#else
>      virtual void openFileSystem(WebFileSystem::Type, long long size, bool
create, WebFileSystemCallbacks*)
> +#endif

Can you use a typedef to avoid adding this ifdef everywhere?