[webkit-reviews] review granted: [Bug 79749] Determine text direction for rendering a TextTrackCue : [Attachment 193568] More test cases

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Victor Carbune
<vcarbune at chromium.org>'s request for review:
Bug 79749: Determine text direction for rendering a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=79749

Attachment 193568: More test cases
https://bugs.webkit.org/attachment.cgi?id=193568&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193568&action=review


Thanks, lgtm!

> Source/WebCore/html/track/TextTrackCue.cpp:591
> +    return WTF::Unicode::category(character) &
WTF::Unicode::Separator_Paragraph;

FYI that this is an expensive, but functionally correct approach. Given the
short size of the content usually being dealt with here, I think this is
probably fine.