[webkit-reviews] review denied: [Bug 112525] AXObjectCache gets recreated during document tear-down : [Attachment 193597] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 10:19:56 PDT 2013


Adam Barth <abarth at webkit.org> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 112525: AXObjectCache gets recreated during document tear-down
https://bugs.webkit.org/show_bug.cgi?id=112525

Attachment 193597: patch
https://bugs.webkit.org/attachment.cgi?id=193597&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193597&action=review


> Source/WebCore/dom/Document.cpp:2214
> +    if (!topDocument()->renderer())
> +	   return false;

Same comment as before.  I think you want to check whether the Document is
detached from the Frame.


More information about the webkit-reviews mailing list