[webkit-reviews] review denied: [Bug 112548] [GTK] Clicking on the volume slider of HTML5 elements is pausing sometimes : [Attachment 193584] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied  review:
Bug 112548: [GTK] Clicking on the volume slider of HTML5 elements is pausing
sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548

Attachment 193584: Patch
https://bugs.webkit.org/attachment.cgi?id=193584&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193584&action=review


Normally, clicking on a playing <video> element will not make it pause. The
only situation that I can think of where a video will pause because of a click
is when it is open in a MediaDocument, where we have a click handler, so I
don't think this test case will ever fail as written.

I think a better test for this change would be to have a click handler on the
<video> element and fail if that fires, rather than if 'pause' fires.

> Source/WebCore/ChangeLog:3
> +	   [GTK] Clicking on the volume slider of HTML5 elements is pausing
sometimes

This change is not GTK-specific, please remove "[GTK]" from the title.

> LayoutTests/media/click-volume-bar-not-pausing.html:44
> +	       setTimeout(finalTest(), 1000);

This makes the test take more than a full second. I a much shorter timeout
should work because the 'pause' event is sent immediately, can you please see
if something like 100 will work?