[webkit-reviews] review granted: [Bug 112548] [GTK] Clicking on the volume slider of HTML5 elements is pausing sometimes : [Attachment 193584] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 112548: [GTK] Clicking on the volume slider of HTML5 elements is pausing
sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548

Attachment 193584: Patch
https://bugs.webkit.org/attachment.cgi?id=193584&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193584&action=review


Goo fix and testcase, with one nit:

> Source/WebCore/ChangeLog:12
> +	   * html/shadow/MediaControlElementTypes.cpp:
> +	   (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
> +	   Setting setDefaultHandled to the event.

I'd like to see more description here, something along the lines of:

"Mouse click events were propagating from the volume button up to the
MediaDocument, causing the video to pause. Call the event's setDefaultHandled()
method to prevent the event from being handled twice."