[webkit-reviews] review denied: [Bug 112564] Refactor Use initiatorType instead of initiatorName in CachedResourceRequest : [Attachment 193548] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 09:00:53 PDT 2013


Adam Barth <abarth at webkit.org> has denied pdeng6 <pan.deng at intel.com>'s request
for review:
Bug 112564: Refactor Use initiatorType instead of initiatorName in
CachedResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=112564

Attachment 193548: Patch
https://bugs.webkit.org/attachment.cgi?id=193548&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193548&action=review


I'm not sure the benefits of this change are worth the code and API churn.

> Source/WebKit/chromium/public/WebCachedURLRequest.h:56
> -    WEBKIT_EXPORT WebString initiatorName() const;
> +    WEBKIT_EXPORT WebString initiatorType() const;

This API change is likely to break code in Chromium that consumes this API.


More information about the webkit-reviews mailing list