[webkit-reviews] review denied: [Bug 98358] [GTK] accessibility/aria-scrollbar-role.html is failing : [Attachment 193565] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 98358: [GTK] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98358

Attachment 193565: Patch
https://bugs.webkit.org/attachment.cgi?id=193565&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193565&action=review


Some unnecessary string duplication going on, but otherwise looks good to me.
:)

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:514
> +    GOwnPtr<gchar> axOrientation;
> +    if (checkElementState(m_element, ATK_STATE_HORIZONTAL))
> +	   axOrientation.set(g_strdup_printf("AXOrientation:
AXHorizontalOrientation"));
> +    else if (checkElementState(m_element, ATK_STATE_VERTICAL))
> +	   axOrientation.set(g_strdup_printf("AXOrientation:
AXVerticalOrientation"));
> +
> +    if (!axOrientation)
> +	   return JSStringCreateWithCharacters(0, 0);
> +
> +    return JSStringCreateWithUTF8CString(axOrientation.get());

See below.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:552
> +    GOwnPtr<gchar> axOrientation;
> +    if (checkElementState(m_element, ATK_STATE_HORIZONTAL))
> +	   axOrientation.set(g_strdup_printf("AXOrientation:
AXHorizontalOrientation"));
> +    else if (checkElementState(m_element, ATK_STATE_VERTICAL))
> +	   axOrientation.set(g_strdup_printf("AXOrientation:
AXVerticalOrientation"));
> +

g_strdump_printf can just be g_strdump and even more simply can just be like
this:

const char* axOrientation = 0;
if (checkElementState(m_element, ATK_STATE_HORIZONTAL))
     axOrientation = "AXOrientation: AXHorizontalOrientation";
...