[webkit-reviews] review granted: [Bug 112470] Web Inspector: support changing local variables in frontend : [Attachment 193379] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 112470: Web Inspector: support changing local variables in frontend
https://bugs.webkit.org/show_bug.cgi?id=112470

Attachment 193379: Patch
https://bugs.webkit.org/attachment.cgi?id=193379&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193379&action=review


Maybe test?

> Source/WebCore/inspector/front-end/RemoteObject.js:59
> +	   this._scopeRef = scopeRef;

Why not do this._scopeRef = scopeRef; unconditionally ?

> Source/WebCore/inspector/front-end/RemoteObject.js:122
> +    console.assert(typeof payload === "object", "Remote object payload
should only be an object");

Do really want to keep this check in production code?

> Source/WebCore/inspector/front-end/RemoteObject.js:286
> +	   

Remove empty line.

> Source/WebCore/inspector/front-end/RemoteObject.js:452
> +    this.scopeHolder = scopeHolder;

I'd merge these two objects.