[webkit-reviews] review denied: [Bug 112531] Network Panel: .swf file is always presented as loading by XHR : [Attachment 193540] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 112531: Network Panel: .swf file is always presented as loading by XHR
https://bugs.webkit.org/show_bug.cgi?id=112531

Attachment 193540: Patch
https://bugs.webkit.org/attachment.cgi?id=193540&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193540&action=review


> Source/WebCore/inspector/InspectorPageAgent.cpp:322
> +	   if
(const_cast<CachedResource&>(cachedResource).resourceRequest().targetType() ==
ResourceRequest::TargetIsXHR)

Platform specific code is not acceptable here.
TargetIsXHR is supposed to be used in chromium network stack and should not be
used by inspector.