[webkit-reviews] review granted: [Bug 112541] The 'formnovalidate' attribute doesn't work correctly on button elements with child elements : [Attachment 193505] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 04:37:46 PDT 2013


Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Kunihiko
Sakamoto <ksakamoto at chromium.org>'s request for review:
Bug 112541: The 'formnovalidate' attribute doesn't work correctly on button
elements with child elements
https://bugs.webkit.org/show_bug.cgi?id=112541

Attachment 193505: Patch
https://bugs.webkit.org/attachment.cgi?id=193505&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193505&action=review


> Source/WebCore/html/HTMLFormElement.cpp:210
> +	       return static_cast<HTMLFormControlElement*>(node);

Oh, we should have toHTMLFormControlElement(). static_cast<> should be avoided.


More information about the webkit-reviews mailing list