[webkit-reviews] review denied: [Bug 112402] Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately. : [Attachment 193521] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 112402: Web Inspector: [Resources] Local Storage: duplicate keys are
processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402

Attachment 193521: Patch
https://bugs.webkit.org/attachment.cgi?id=193521&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review


> Source/WebCore/ChangeLog:8
> +	   Avoid duplicates in case value is not updated (consequently,

Please give a more detailed description of what's wrong and how this patch
fixes the bug (the issue summary is not helpful either.)

> Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250
> +	   masterNode.select();

Either this line should follow the method call or the method should be named,
_removeDupesAndSelect.