[webkit-reviews] review granted: [Bug 112527] INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes : [Attachment 193476] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Kunihiko
Sakamoto <ksakamoto at chromium.org>'s request for review:
Bug 112527: INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of
minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527

Attachment 193476: Patch
https://bugs.webkit.org/attachment.cgi?id=193476&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193476&action=review


> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:67
> -DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document,
FieldOwner& fieldOwner, int minimum, int maximum, const String& placeholder,
const DateTimeNumericFieldElement::Parameters& parameters)
> +DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document,
FieldOwner& fieldOwner, const Range& range, const Range& hardLimits, const
String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters)

>      : DateTimeFieldElement(document, fieldOwner)
>      , m_lastDigitCharTime(0)
>      , m_placeholder(placeholder)
> -    , m_range(minimum, maximum)
> +    , m_range(range)
> +    , m_hardLimits(hardLimits)

nit: We should have made this change before this bug to minimize the size of
each patches.