[webkit-reviews] review granted: [Bug 112256] Add touch support to the calendar picker : [Attachment 193249] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 112256: Add touch support to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=112256

Attachment 193249: Patch
https://bugs.webkit.org/attachment.cgi?id=193249&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193249&action=review


> Source/WebCore/Resources/pagepopups/calendarPicker.js:1137
> +function FlingGestureAnimator(initialVelocity, initialValue) {

Need a JsDoc comment

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1177
> +FlingGestureAnimator.P0 = -5707.62;
> +FlingGestureAnimator.P1 = 0.172;
> +FlingGestureAnimator.P2 = 0.0037;

The names P0/P1/P2 are not descriptive. Please add comments or rename them.
They should be private.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:3311
> +    // you shouldn't be able to do gesture scroll.

nit: y -> Y