[webkit-reviews] review granted: [Bug 112505] [wk2] Should support multiple page overlays, like the API suggests : [Attachment 193457] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 112505: [wk2] Should support multiple page overlays, like the API suggests
https://bugs.webkit.org/show_bug.cgi?id=112505

Attachment 193457: patch
https://bugs.webkit.org/attachment.cgi?id=193457&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193457&action=review


> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:732
> +	       Vector<RefPtr<PageOverlay> >& pageOverlays =
m_webPage->pageOverlays();
> +	       Vector<RefPtr<PageOverlay> >::iterator end = pageOverlays.end();

> +	       for (Vector<RefPtr<PageOverlay> >::iterator it =
pageOverlays.begin(); it != end; ++it)

A typedef for Vector<RefPtr<PageOverlay> > would clean this up.

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h:96
> +    PageOverlayLayerMap m_pageOverlays;

I think m_pageOverlays would be better called m_pageOverlayLayers