[webkit-reviews] review denied: [Bug 112445] Support connecting the Web Inspector without showing it : [Attachment 193437] Proposed Change (Take 3)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 16 19:28:23 PDT 2013
Sam Weinig <sam at webkit.org> has denied Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 112445: Support connecting the Web Inspector without showing it
https://bugs.webkit.org/show_bug.cgi?id=112445
Attachment 193437: Proposed Change (Take 3)
https://bugs.webkit.org/attachment.cgi?id=193437&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193437&action=review
> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:413
> + WKView *inspectedView = m_page->wkView();
Please don't access the WKView directly here (that function should be removed).
Instead, this should go through the PageClient.
More information about the webkit-reviews
mailing list