[webkit-reviews] review granted: [Bug 112475] Add IDL 'enum' support to CodeGeneratorJS.pm : [Attachment 193411] updated patch: check for exception after calling toString()

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted arno. <arno at renevier.net>'s
request for review:
Bug 112475: Add IDL 'enum' support to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112475

Attachment 193411: updated patch: check for exception after calling toString()
https://bugs.webkit.org/attachment.cgi?id=193411&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193411&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2134
> +				       push(@implContent, "    String string =
value.isEmpty() ? String() : value.toString(exec)->value(exec);\n");

Don't you need to add 'if (exec->hadException()) return' ?