[webkit-reviews] review denied: [Bug 112496] Web Inspector: Flame Chart. Provide Overview Timeline Grid with curtains for better user expirience : [Attachment 193433] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 112496: Web Inspector: Flame Chart. Provide Overview Timeline Grid with
curtains for better user expirience
https://bugs.webkit.org/show_bug.cgi?id=112496

Attachment 193433: Patch
https://bugs.webkit.org/attachment.cgi?id=193433&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193433&action=review


> Source/WebCore/inspector/front-end/FlameChart.js:442
> +	       this._overviewTimelineGrid.element.style.width =
this._overviewContainer.clientHeight;

width = height?

> Source/WebCore/inspector/front-end/FlameChart.js:444
> +	      
this._overviewTimelineGrid.showCurtains(this._overviewCalculator._gapOffset,
this._overviewCalculator._gapWidth);

Curtains should be removed from that component. They are for a different thing.
You should add draggable window here.

> Source/WebCore/inspector/front-end/flameChart.css:30
> +    left: 0px;

timeline-cpu style is private to timeline. it should load lazily with timeline
panel so it won't apply here.