[webkit-reviews] review denied: [Bug 112474] REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData() : [Attachment 193391] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Andy Estes
<aestes at apple.com>'s request for review:
Bug 112474: REGRESSION (r145820): Stop over-retaining CFDataRefs in
SharedBuffer::maybeTransferPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=112474

Attachment 193391: Patch
https://bugs.webkit.org/attachment.cgi?id=193391&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review


> Source/WebCore/platform/cf/SharedBufferCF.cpp:86
> +    RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef());

This should just assign.