[webkit-reviews] review denied: [Bug 112156] New context extensions restored improperly : [Attachment 193376] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 15 15:04:30 PDT 2013


Rob Buis <rwlbuis at gmail.com> has denied R S <rsarvaria at blackberry.com>'s
request for review:
Bug 112156: New context extensions restored improperly
https://bugs.webkit.org/show_bug.cgi?id=112156

Attachment 193376: Patch
https://bugs.webkit.org/attachment.cgi?id=193376&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193376&action=review


Please explain a bit better.

> Source/WebCore/ChangeLog:9
> +	   Previous extensions set up is lost when context is initially lost.

Add empty line here.

> Source/WebCore/ChangeLog:10
> +	   Cannot create a test as change is not visible from the web.

On irc you gave a more in-depth reason, please combine with this remark.


More information about the webkit-reviews mailing list