[webkit-reviews] review granted: [Bug 110837] Convert old flexbox uses in html.css to new flexbox (non-<select>) : [Attachment 193203] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 110837: Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Attachment 193203: Patch
https://bugs.webkit.org/attachment.cgi?id=193203&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193203&action=review


Yay!

> Source/WebCore/rendering/RenderTextControl.cpp:330
> +RenderTextControlInnerContainer::RenderTextControlInnerContainer(Element*
element)
> +    : RenderFlexibleBox(element)
> +{
> +}
> +
> +RenderTextControlInnerContainer::~RenderTextControlInnerContainer()
> +{
> +}

I think typically we'd just put these directly in the header.

> Source/WebCore/rendering/RenderTextControl.h:103
> +// baseline definition, and then inputs of different types wouldn't like up

s/like/line