[webkit-reviews] review granted: [Bug 112395] Convert <select> to new-flexbox : [Attachment 193206] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 112395: Convert <select> to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112395

Attachment 193206: Patch
https://bugs.webkit.org/attachment.cgi?id=193206&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193206&action=review


> Source/WebCore/rendering/RenderMenuList.h:123
> +    virtual int baselinePosition(FontBaseline baseline, bool firstLine,
LineDirectionMode direction, LinePositionMode position) const OVERRIDE
> +    {
> +	   return RenderBlock::baselinePosition(baseline, firstLine, direction,
position);
> +    }
> +    virtual int firstLineBoxBaseline() const OVERRIDE { return
RenderBlock::firstLineBoxBaseline(); }
> +    virtual int inlineBlockBaseline(LineDirectionMode direction) const
OVERRIDE { return RenderBlock::inlineBlockBaseline(direction); }

I think this deserves a comment in the code explaining *why* we need to
override these. Something like...
// Flexbox defines baselines differently than regular blocks.
// For backwards compatibility, menulists need to do the regular block
behavior.