[webkit-reviews] review granted: [Bug 112400] [iOS] Update StringImpl's equal to have a single version on all supported Apple CPUs : [Attachment 193354] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 112400: [iOS] Update StringImpl's equal to have a single version on all
supported Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112400

Attachment 193354: Patch
https://bugs.webkit.org/attachment.cgi?id=193354&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193354&action=review


I'd prefer a little more descriptive labels, but that predates this patch.

> Source/WTF/ChangeLog:15
> +	    each iteration and work in the negative space for the tail. This
free one register

typo, should be "frees"

> Source/WTF/ChangeLog:18
> +	    negative space, we can test for the Carry flag to jumb back to the
next LDR.

typo, should be "jump"