[webkit-reviews] review granted: [Bug 112457] Determine background visibility at layout time : [Attachment 193352] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 112457: Determine background visibility at layout time
https://bugs.webkit.org/show_bug.cgi?id=112457

Attachment 193352: patch
https://bugs.webkit.org/attachment.cgi?id=193352&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193352&action=review


> Source/WebCore/ChangeLog:8
> +	   We can put more effort into this in layout time as there are less
layouts than paints.

fewer layouts

> Source/WebCore/rendering/RenderBox.h:596
> +    virtual void determineIsBackgroundKnownToBeObscured();

Awkward name. Maybe updateBackgroundKnownToBeObscured() or
computeBackgroundObscurity()

> Source/WebCore/rendering/RenderObject.h:691
> +    void setIsBackgroundKnownToBeObscured(bool b) {
m_bitfields.setIsBackgroundKnownToBeObscured(b); }

Should be setBackgroundIsKnownToBeObscured

> Source/WebCore/rendering/RenderObject.h:1114
> +	   ADD_BOOLEAN_BITFIELD(isBackgroundKnownToBeObscured,
IsBackgroundKnownToBeObscured);

Member should be called backgroundIsKnownToBeObscured or just
backgroundKnownToBeObscured