[webkit-reviews] review granted: [Bug 100299] [CSS Exclusions] shape-outside on floats for rounded rectangle shapes : [Attachment 193155] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted  review:
Bug 100299: [CSS Exclusions] shape-outside on floats for rounded rectangle
shapes
https://bugs.webkit.org/show_bug.cgi?id=100299

Attachment 193155: Patch
https://bugs.webkit.org/attachment.cgi?id=193155&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193155&action=review


> LayoutTests/fast/exclusions/resources/rounded-rectangle.js:23
> +    if (lineTop < dimensions.shapeHeight && lineBottom >
dimensions.shapeHeight)

Part of this code is confusing and unneeded: you can't have lineTop >=
dimensions.shapeHeight the way you are calling xOutset.

> LayoutTests/fast/exclusions/resources/rounded-rectangle.js:141
> +	   + dimensions.shapeRadiusX + "px, "
> +	   + dimensions.shapeRadiusY + "px); "

The specification has a 'curve' keyword before these 2. Couldn't find a bug
about it though.