[webkit-reviews] review granted: [Bug 112385] [Chromium] Focus Plugin on TouchStart : [Attachment 193193] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 112385: [Chromium] Focus Plugin on TouchStart
https://bugs.webkit.org/show_bug.cgi?id=112385

Attachment 193193: Patch
https://bugs.webkit.org/attachment.cgi?id=193193&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193193&action=review


> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:779
> +	       Frame* containingFrame =
static_cast<FrameView*>(parent())->frame();
> +	       if (Page* currentPage = containingFrame->page())
> +		   currentPage->focusController()->setFocusedNode(m_element,
containingFrame);
> +	       else
> +		   containingFrame->document()->setFocusedNode(m_element);

This seems copy/pasted from WebPluginContainerImpl::handleMouseEvent.  Can we
create a small helper function rather than copy/pasting code?