[webkit-reviews] review denied: [Bug 112398] Auto height column flexboxes with border and padding are too short : [Attachment 193220] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 112398: Auto height column flexboxes with border and padding are too short
https://bugs.webkit.org/show_bug.cgi?id=112398

Attachment 193220: Patch
https://bugs.webkit.org/attachment.cgi?id=193220&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193220&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:750
> +	   LayoutUnit availableFreeSpace =
mainAxisContentExtent(preferredMainAxisExtent + borderAndPaddingLogicalHeight()
+ scrollbarLogicalHeight()) - preferredMainAxisExtent;

This can't be correct for horizontal flexbox.

> LayoutTests/css3/flexbox/auto-height-column-with-border-and-padding.html:5
> +    <div class="flex-one-one-auto" style="min-height: 0"
data-expected-height=50>

It looks like the min-height is needed, but it's not clear to me why it's
needed.  Why does adding a min-heigth change the available free space?