[webkit-reviews] review granted: [Bug 112440] Web Inspector: Allow toolbar customization : [Attachment 193299] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 112440: Web Inspector: Allow toolbar customization
https://bugs.webkit.org/show_bug.cgi?id=112440

Attachment 193299: Patch
https://bugs.webkit.org/attachment.cgi?id=193299&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193299&action=review


> Source/WebCore/inspector/front-end/Toolbar.js:131
> +	       count += this._isPanelVisible(this._panelDescriptors[i].name())
? 1 : 0;

if (this._isPanelVisible(this._panelDescriptors[i].name()))
    ++count;

> Source/WebCore/inspector/front-end/Toolbar.js:153
> +	   var index = this._panelDescriptors.indexOf(panelDescriptor);

var index = ... + 1

> Source/WebCore/inspector/front-end/inspector.css:286
> +    font-weight: bold;

Consider sharing common properties with #toolbar-dropdown-arrow

> Source/WebCore/inspector/front-end/inspector.js:48
> +	   var allDescriptors = [elements, console, network, scripts, timeline,
profiles, audits, resources];

Do it in a separate change please.