[webkit-reviews] review granted: [Bug 112376] DFG string conversions and allocations should be inlined : [Attachment 193252] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 112376: DFG string conversions and allocations should be inlined
https://bugs.webkit.org/show_bug.cgi?id=112376

Attachment 193252: the patch
https://bugs.webkit.org/attachment.cgi?id=193252&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193252&action=review


r=me, plz to fix Windows before landing.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:899
> +	   if
(stringPrototypeStructure->transitionWatchpointSetHasBeenInvalidated())
> +	       return false;

It's pretty good that we set up all the string built-ins in advance, and don't
set this watchpoint until the first DFG-optimized string access. I still think
it would be even better if we had a specific watchpoint for overriding
toString() and valueOf(). Mark's data convinced me that libraries will add to
the string prototype, but won't override toString() and valueOf().

> Tools/ChangeLog:11
> +	   * Scripts/integrate-fast-js-tests: Added.

Does this duplicate make-script-test-wrappers or make-new-script-test?