[webkit-reviews] review granted: [Bug 112397] REGRESSION: -webkit-box-reflect does not show on video elements : [Attachment 193317] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 112397: REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Attachment 193317: Patch
https://bugs.webkit.org/attachment.cgi?id=193317&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193317&action=review


r=me but please make sure the pixel result is correct.

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:277
> +	   [newLayer->playerLayer() setPlayer:[playerLayer() player]];

Most ridiculous-sounding line of code ever.

> LayoutTests/ChangeLog:8
> +	   * compositing/video/video-reflection-expected.png: Added.

Is this supposed to be all dark gray?