[webkit-reviews] review denied: [Bug 111688] Web Inspector: Details of InjectedScript function call shall not be linkified in Timeline panel. : [Attachment 192854] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 111688: Web Inspector: Details of InjectedScript function call shall not be
linkified in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=111688

Attachment 192854: Patch
https://bugs.webkit.org/attachment.cgi?id=192854&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192854&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1132
> +	       this._validScriptLocation = this.scriptName ?
!!this.scriptName.asParsedURL() : false;

I think it's possible that a script with the name that could not be correctly
parsed can still be correctly linkified (think sourceURL).
Such false negative would be a much worse issue than current false positive
behavior.