[webkit-reviews] review denied: [Bug 112411] WebKitCSSKeyframesRule.idl should have item method : [Attachment 193243] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Koji Hara <kojih at chromium.org>'s
request for review:
Bug 112411: WebKitCSSKeyframesRule.idl should have item method
https://bugs.webkit.org/show_bug.cgi?id=112411

Attachment 193243: Patch
https://bugs.webkit.org/attachment.cgi?id=193243&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193243&action=review


> Source/WebCore/ChangeLog:10
> +	   There is WebKitCSSKeyframesRule::item() method but
WebKitCSSKeyframesRule.idl doesn't have item method.
> +	   Currently CodeGeneratorV8 have to treat WebKitCSSKeyframesRule
specially due to lack of item() definition.
> +	   (On the other hand it seems that JSC generator doesn't need to get
IndexGetter's return type from IDL.)

What is the spec saying? We should follow the spec.

> Source/WebCore/ChangeLog:12
> +	   No new tests, refactoring only. No run-bindings-tests changes.

This is not refactoring. You're changing behavior that is exposed to outside.
You have to add layout tests. (But before that I'd like to confirm what the
spec is saying.)