[webkit-reviews] review granted: [Bug 112409] Collect samples for unresponsive web processes : [Attachment 193239] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 112409: Collect samples for unresponsive web processes
https://bugs.webkit.org/show_bug.cgi?id=112409

Attachment 193239: Patch
https://bugs.webkit.org/attachment.cgi?id=193239&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193239&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:172
> +	   self._write_text_file(filename,
self._filesystem.read_text_file(sample_file))

_filesystem.copyfile?

> Tools/Scripts/webkitpy/layout_tests/port/mac.py:190
> +	   return self._filesystem.join(self.results_directory(),
"%s-%s-sample.txt" % (name, pid))

%-formatting is deprecated (or at least frowned upon, I'm not sure). I see a
lot of it around, but "{0}-{1}-sample.txt".format(name, pid) is the way of the
future. Less magic syntax ftw.