[webkit-reviews] review granted: [Bug 35372] Backspace/delete at start of table cell shouldn't step out of cell : [Attachment 192988] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 35372: Backspace/delete at start of table cell shouldn't step out of cell
https://bugs.webkit.org/show_bug.cgi?id=35372

Attachment 192988: Patch
https://bugs.webkit.org/attachment.cgi?id=192988&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192988&action=review


> LayoutTests/editing/deleting/backspace-at-table-cell-beginning.html:11
> +		       + "a table-cell is a no-op.  The first dump verifies "
> +		       + "that the caret stays before 'abc', and doesn't select
"
> +		       + "the nested table.  The second dump verifies that the
"
> +		       + "caret stays before 'def'.");

Wrong indentation. + should be indented by exactly 4 spaces.
By the way, I usually prefer putting this description in p with id=description
and then do:
Markup.description(document.getElementById('description').textContent);
There's an added benefit that we can automate this in the future.

> LayoutTests/editing/deleting/forward-delete-at-table-cell-ending.html:12
> +Markup.description("This test verifies that forward delete at the end of a "

> +		       + "table-cell is a no-op.  The first dump verifies that
"
> +		       + "the caret stays after 'abc'.	The second dump
verifies "
> +		       + "that the caret stays after 'def', and doesn't select
"
> +		       + "the nested table.");

Ditto about the wrong indentation.