[webkit-reviews] review denied: [Bug 112275] TextIterator emits LF for a br element inside an empty input element : [Attachment 193216] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 19:30:23 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied Aurimas Liutikas
<aurimas at chromium.org>'s request for review:
Bug 112275: TextIterator emits LF for a br element inside an empty input
element
https://bugs.webkit.org/show_bug.cgi?id=112275

Attachment 193216: Patch
https://bugs.webkit.org/attachment.cgi?id=193216&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193216&action=review


> Source/WebCore/editing/TextIterator.cpp:1139
> +    , m_emitsOriginalText(behavior & TextIteratorEmitsOriginalText)

SimplifiedBackwardsTextIterator doesn't support TextIteratorEmitsOriginalText.
We need to initialize it with false.
r- because of this.


More information about the webkit-reviews mailing list