[webkit-reviews] review denied: [Bug 70634] Mark GraphicsLayers as opaque when possible : [Attachment 193174] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 70634: Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Attachment 193174: Patch
https://bugs.webkit.org/attachment.cgi?id=193174&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193174&action=review


> Source/WebCore/rendering/RenderBox.cpp:1134
> +	   if (documentElementRenderer &&
!documentElementRenderer->hasBackground() && documentElementRenderer ==
parent() && !isComposited)
>	       return;

This is wrong. The change is causing the body background to be rendered twice
sometimes (once into the page layer, once into the body layer), and you're only
doing this to work around deficiencies in the "is opaque" logic.